-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocBLAS: Add an option to disable tensile #28846
Conversation
- Change variant name to be consistent with rocsolver - Change default variant value to be consistent with rocsolver
@cgmb ,can you please review it |
Does rocSOLVER build with |
The package builds fine. However, I checked for missing symbols and indeed |
@cgmb do you think rocblas could have a fallback gemm that's quick to build? |
That's been on my personal wishlist for a while... but I have a rather long wishlist. My suggestion would be to open an issue requesting the feature from rocBLAS. |
I haven't actually tested it, but I like this change aside from the default amdgpu_target. |
There will be some minor merge conflicts to resolve if #27436 is merged first, but they should be pretty easy to deal with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The defaults on the variants are not appropriate. This should not be merged until they're changed.
By the way, there are build speed improvements coming for Tensile in ROCm 5.0/5.1, so you do have something to look forward to.
I addressed the comments regarding the default variant and copied the changes for the variant from #28907 for rocblas. This now has the same changes for rocblas as in #28907 except that the default for tensile is set to True. If merging this PR before #28907 is preferable, then this can be merged, if not, then this PR can be closed and only #28907 can be merged (after the default value is changed there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change still needs testing to verify it doesn't break anything, but the code looks good.
It has been merged, so the conflicts will need to be resolved. |
This PR was closed because it was subsumed into #28907. I talked with the rocBLAS team about this and they were receptive to fleshing out the |
Ideally Tensile should be a separate package but that can be handled in a different PR.