Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #238: Database specs need to be concrete when read in as well. #239

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

tgamblin
Copy link
Member

@lee218llnl: please merge if this works for you.

@lee218llnl
Copy link
Contributor

still seeing:

cab687@lee218:spack uninstall libxml2
Traceback (most recent call last):
File "/nfs/tmp2/lee218/pkg/spack3/spack/bin/spack", line 163, in
main()
File "/nfs/tmp2/lee218/pkg/spack3/spack/bin/spack", line 144, in main
return_val = command(parser, args)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/cmd/uninstall.py", line 96, in uninstall
pkg.do_uninstall(force=args.force)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/package.py", line 932, in do_uninstall
spack.hooks.pre_uninstall(self)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/hooks/init.py", line 69, in call
hook(pkg)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/hooks/extensions.py", line 35, in pre_uninstall
if pkg.activated:
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/package.py", line 518, in activated
exts = spack.install_layout.extension_map(self.extendee_spec)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/directory_layout.py", line 343, in extension_map
_check_concrete(spec)
File "/nfs/tmp2/lee218/pkg/spack3/spack/lib/spack/spack/directory_layout.py", line 44, in _check_concrete
raise ValueError('Specs passed to a DirectoryLayout must be concrete!')
ValueError: Specs passed to a DirectoryLayout must be concrete!

@lee218llnl
Copy link
Contributor

Per the request of @tgamblin, we can merge this, since this will benefit other issues, although additional work still needs to be done for the error that still occurs.

lee218llnl added a commit that referenced this pull request Dec 16, 2015
Fix #238: Database specs need to be concrete when read in as well.
@lee218llnl lee218llnl merged commit 9cab880 into develop Dec 16, 2015
@tgamblin tgamblin deleted the bugfix/238-db-specs-not-concrete branch December 20, 2015 22:33
matz-e added a commit to matz-e/spack that referenced this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants