Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added packaging files for ATLAS with and without netlib's LAPACK #20

Closed
wants to merge 7 commits into from

Conversation

kjbrandstatter
Copy link
Contributor

I've created packaging scripts for the ATLAS library, one as a standalone, and the other built using netlib's lapack library.

@tgamblin
Copy link
Member

tgamblin commented Mar 4, 2015

Cool! You can get to a dependency's prefix with spec['depname'].prefix, so here it'd be spec['atlas'].prefix. There's a bit more about that in the packaging guide, under install environment, prefix objects, and spec objects: http://scalability-llnl.github.io/spack/packaging_guide.html

@kjbrandstatter
Copy link
Contributor Author

Thanks that worked. I was able to get spack to build and install LAPACK using the installed ATLAS libs.

@tgamblin
Copy link
Member

tgamblin commented Mar 4, 2015

Great! Let me see if I can get this built at LLNL, and I can then merge your feature in. I may need to get access to a node that doesn't have frequency throttling, so I may not get back to you until tomorrow.

Is the atlas-lapack package needed anymore? What about the FIXME comments?

@kjbrandstatter
Copy link
Contributor Author

sounds good. Since the lapack build works with an installed atlas, the lapack-atlas package is probably unecessary and could be removed. I should have removed all the FIXME comments from the atlas and lapack packages, except for the header because I'm not sure exactly what to put there.

@tgamblin tgamblin self-assigned this Mar 19, 2015
@tgamblin
Copy link
Member

tgamblin commented Jun 7, 2015

This is integrated into develop, and integrated with Ben and Saravan's PRs. I cannot get ATLAS to build right on our machines, so I've commented out provides('blas') until I can actually test it. But it is there and you can make it resolve blas dependencies by uncommenting that.

@tgamblin tgamblin closed this Jun 7, 2015
@tgamblin
Copy link
Member

tgamblin commented Jun 7, 2015

Thanks for sending the PR!

matz-e pushed a commit to matz-e/spack that referenced this pull request Sep 3, 2018
matz-e pushed a commit to matz-e/spack that referenced this pull request Oct 1, 2018
matz-e pushed a commit to matz-e/spack that referenced this pull request Jan 28, 2019
gartung referenced this pull request in gartung/spack Mar 28, 2019
* Checkpoint for ROOT reconciliation.

* Model on root's patch e0ae0483985d90a71a6cabd10d3622dfd1c15611.

* Feature/fnal root update (#17)

* Build the version of ftgl which has the  header FTGL/ftgl.h the ROOT expects.

* ftgl patch borrowed from source rpm

* Define FTGL_ROOT_DIR and FTGL_INCLUDE_DIR when spec contains +x+opengl

* ftgl: flake8 issues.
fcannini pushed a commit to fcannini/spack that referenced this pull request Oct 29, 2019
…elop

* commit 'ccfc6246ca1cde02779873e3ec87ca55026e086a':
  openblas: Hygiene is a good thing.
amd-toolchain-support referenced this pull request in amd-toolchain-support/spack Mar 17, 2021
* Added architecture flags for AOCC compiler
@pghysels pghysels mentioned this pull request Oct 21, 2021
4 tasks
climbfuji added a commit to climbfuji/spack that referenced this pull request Mar 18, 2022
tldahlgren pushed a commit that referenced this pull request Apr 21, 2023
1. support version 3.1.3, which now depends on sundials@6

2. support version 3.1.2:, which broke the two patch files and
   therefore the two patch files have been replaced by more flexible
   filter_file() commands inside a patch() function.

3. rename the variant for python extension from using the package name
   "+pyuqtk" to the more standard "+python"

4. add maintainers @omsai and the upstream developer @bjdebus who
   offered to help with the spack packaging.

5. swig should only be a build-time dependency.  swig is only
   necessary until @:3.1.0

6. confirmed python dependencies are correct by inspecting imports,
   subset python dependencies type to build, run, and confirmed all
   31 build-time tests pass including the 9 python tests:

```console
$ spack env create uqtk-dev
$ spack add uqtk@3.1.3
$ spack install --test root && cat $(spack location -i uqtk)/.spack/install-time-test-log.txt
==> Testing package uqtk-3.1.3-nok6fut
==> [2023-04-19-14:56:25.005361] Running build-time tests
==> [2023-04-19-14:56:25.005536] RUN-TESTS: build-time tests [check]
==> [2023-04-19-14:56:25.009543] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' '-n' 'test'
==> [2023-04-19-14:56:25.014903] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' 'test'
Running tests...
/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/cmake-3.26.3-zjmsfz23j5l4ytniz26uzvxonlu5qebr/bin/ctest --force-new-ctest-process
Test project /tmp/omsai/spack-stage/spack-stage-uqtk-3.1.3-nok6fut47h42cnaau7wkoohgqy5f2qqa/spack-build-nok6fut
      Start  1: ArrayReadAndWrite
      Start  2: ArrayDelColumn
      Start  3: Array1DMiscTest
      Start  4: Array2DMiscTest
 1/31 Test  #1: ArrayReadAndWrite ................   Passed    0.01 sec
      Start  5: ArraySortTest
 2/31 Test  #2: ArrayDelColumn ...................   Passed    0.01 sec
      Start  6: MultiIndexTest
 3/31 Test  #3: Array1DMiscTest ..................   Passed    0.01 sec
      Start  7: CorrTest
 4/31 Test  #4: Array2DMiscTest ..................   Passed    0.01 sec
      Start  8: QuadLUTest
 5/31 Test  #5: ArraySortTest ....................   Passed    0.02 sec
      Start  9: MCMC2dTest
 6/31 Test  #6: MultiIndexTest ...................   Passed    0.01 sec
      Start 10: MCMCRandomTest
 7/31 Test  #8: QuadLUTest .......................   Passed    0.02 sec
      Start 11: MCMCNestedTest
 8/31 Test #10: MCMCRandomTest ...................   Passed    0.02 sec
      Start 12: Deriv1dTest
 9/31 Test #12: Deriv1dTest ......................   Passed    0.01 sec
      Start 13: SecondDeriv1dTest
10/31 Test #13: SecondDeriv1dTest ................   Passed    0.01 sec
      Start 14: GradHessianTest
11/31 Test #11: MCMCNestedTest ...................   Passed    0.03 sec
      Start 15: GradientPCETest
12/31 Test #14: GradHessianTest ..................   Passed    0.01 sec
      Start 16: PCE1dTest
13/31 Test #15: GradientPCETest ..................   Passed    0.01 sec
      Start 17: PCEImplTest
14/31 Test #16: PCE1dTest ........................   Passed    0.01 sec
      Start 18: PCELogTest
15/31 Test #18: PCELogTest .......................   Passed    0.01 sec
      Start 19: Hessian2dTest
16/31 Test #19: Hessian2dTest ....................   Passed    0.01 sec
      Start 20: BCS1dTest
17/31 Test #20: BCS1dTest ........................   Passed    0.01 sec
      Start 21: BCS2dTest
18/31 Test #21: BCS2dTest ........................   Passed    0.01 sec
      Start 22: LowRankRegrTest
19/31 Test #22: LowRankRegrTest ..................   Passed    0.01 sec
      Start 23: PyModTest
20/31 Test #17: PCEImplTest ......................   Passed    0.07 sec
      Start 24: PyArrayTest
21/31 Test #23: PyModTest ........................   Passed    0.08 sec
      Start 25: PyArrayTest2
22/31 Test #25: PyArrayTest2 .....................   Passed    0.30 sec
      Start 26: PyQuadTest
23/31 Test #24: PyArrayTest ......................   Passed    1.44 sec
      Start 27: PyBCSTest1D
24/31 Test #26: PyQuadTest .......................   Passed    1.68 sec
      Start 28: PyBCSTest2D
25/31 Test #27: PyBCSTest1D ......................   Passed    1.66 sec
      Start 29: PyBADPTest
26/31 Test  #7: CorrTest .........................   Passed    3.43 sec
      Start 30: PyRegressionTest
27/31 Test #28: PyBCSTest2D ......................   Passed    1.50 sec
      Start 31: PyGalerkinTest
28/31 Test  #9: MCMC2dTest .......................   Passed    3.90 sec
29/31 Test #29: PyBADPTest .......................   Passed    1.66 sec
30/31 Test #30: PyRegressionTest .................   Passed    1.72 sec
31/31 Test #31: PyGalerkinTest ...................   Passed    1.63 sec

100% tests passed, 0 tests failed out of 31

Total Test time (real) =   5.35 sec
==> [2023-04-19-14:56:30.382797] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' '-n' 'check'
==> [2023-04-19-14:56:30.385983] Target 'check' not found in Makefile
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants