Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starfish installation guide for JOSS submission #1868

Merged
merged 5 commits into from
Apr 15, 2020

Conversation

mattcai
Copy link
Contributor

@mattcai mattcai commented Apr 13, 2020

See it on read the docs here

List of changes:

  • Emphasized recommendation to use Python 3.7
  • Added clarification for using venv and Jupyter notebooks
  • Moved installation for developers to 'Contributing to starfish'
  • Changed installation for windows section to no longer use WSL

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #1868 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         168      168           
  Lines        5785     5785           
=======================================
  Hits         5078     5078           
  Misses        707      707           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb975c...10d502b. Read the comment docs.

Copy link
Collaborator

@neuromusic neuromusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic. nice additions. a couple of requested changes re: napari

mattcai and others added 2 commits April 14, 2020 23:07
Co-Authored-By: Justin Kiggins <justin.kiggins@chanzuckerberg.com>
Co-Authored-By: Justin Kiggins <justin.kiggins@chanzuckerberg.com>
@mattcai mattcai merged commit c076c61 into master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants