Fix on-demand calculation of BinaryMaskCollection's regionprops #1819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through most ways of constructing BinaryMaskCollections, we calculate region properties and store them with our BinaryMaskCollection. However, on a few code paths (notably
from_binary_arrays_and_ticks
andfrom_fiji_roi_set
), we calculate the regionprops on demand.This code path was not properly tested and we were not generating the regionprops correctly. This fixes the problem and adds a quick sanity test.
Test plan: test passes with changes, does not otherwise.