Fix stain generation in watershed #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
- Coverage 90.1% 90.09% -0.02%
==========================================
Files 231 231
Lines 8835 8835
==========================================
- Hits 7961 7960 -1
- Misses 874 875 +1
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Dec 3, 2019
ttung
force-pushed
the
tonytung-fix-watershed-levels
branch
from
dd3f8b1 to
f73d082
Compare
#1652 replaced a block of code that scales the intensity of the image by the max, with a reduce operation that does Clip.SCALE_BY_IMAGE. As I discovered later, Clip.SCALE_BY_IMAGE does not do what the documentation says it does, and in fact, it only scales by the max intensity if the max intensity is > 1.0. That means it's not a refactor and actually affected the output. Levels.SCALE_BY_IMAGE, however, does what we want here and can do what we originally had here. Depends on #1669 Test plan: pretty much none.
ttung
force-pushed
the
tonytung-fix-watershed-levels
branch
from
f73d082 to
1cf1b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1652 replaced a block of code that scales the intensity of the image by the max, with a reduce operation that does Clip.SCALE_BY_IMAGE. As I discovered later, Clip.SCALE_BY_IMAGE does not do what the documentation says it does, and in fact, it only scales by the max intensity if the max intensity is > 1.0. That means it's not a refactor and actually affected the output.
Levels.SCALE_BY_IMAGE, however, does what we want here and can do what we originally had here.
Depends on #1669
Test plan: pretty much none.