Create an ArrayLike type #1649
Merged
Create an ArrayLike type #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-arraylike
branch
from
ca699bc to
af5f766
Compare
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
+ Coverage 89.67% 89.67% +<.01%
==========================================
Files 220 220
Lines 8232 8236 +4
==========================================
+ Hits 7382 7386 +4
Misses 850 850
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-arraylike
branch
from
af5f766 to
06962de
Compare
shanaxel42
approved these changes
Nov 16, 2019
This is an array-like type that accepts ndarray, DataArray, or a sequence of a numeric type. Test plan: none!
ttung
force-pushed
the
tonytung-arraylike
branch
from
06962de to
c578cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an array-like type that accepts ndarray, DataArray, or a sequence of a numeric type.
I remember we talked about doing this, but I can't seem to find any issue to connect this to. :/
Test plan: none!