Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that binary masks can be generated from empty label images #1634

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 30, 2019

This results in a binary mask with zero masks. Verify that this isn't a corner case that doesn't work.

Test plan: this is the test.
Depends on #1631

@ttung ttung requested a review from shanaxel42 October 30, 2019 20:40
@ttung ttung force-pushed the tonytung-empty-label-array branch from 17b1e08 to deb46e5 Compare October 30, 2019 20:41
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1634 into master will decrease coverage by 0.03%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage    89.7%   89.67%   -0.04%     
==========================================
  Files         220      220              
  Lines        8219     8232      +13     
==========================================
+ Hits         7373     7382       +9     
- Misses        846      850       +4
Impacted Files Coverage Δ
...hology/object/binary_mask/test/test_binary_mask.py 94.28% <95%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c077a...5a4ed4a. Read the comment docs.

@ttung ttung force-pushed the tonytung-empty-label-array branch 2 times, most recently from 2fb5e66 to 190d571 Compare October 31, 2019 04:15
@ttung ttung force-pushed the tonytung-morphology branch from 3833c11 to ad49273 Compare October 31, 2019 17:16
@ttung ttung force-pushed the tonytung-empty-label-array branch from 190d571 to 4a61a76 Compare October 31, 2019 17:16
@ttung ttung force-pushed the tonytung-morphology branch from ad49273 to e5fdcf2 Compare October 31, 2019 17:48
@ttung ttung force-pushed the tonytung-empty-label-array branch from 4a61a76 to c78a487 Compare October 31, 2019 17:48
@ttung ttung force-pushed the tonytung-morphology branch from e5fdcf2 to a1a12d0 Compare November 7, 2019 09:31
@ttung ttung force-pushed the tonytung-empty-label-array branch 2 times, most recently from 3e80f85 to 467b297 Compare November 7, 2019 22:49
@ttung ttung force-pushed the tonytung-morphology branch from 3338aae to 62293de Compare November 13, 2019 06:39
@ttung ttung force-pushed the tonytung-empty-label-array branch 3 times, most recently from fc5e63f to afd6797 Compare November 13, 2019 16:05
@ttung ttung changed the base branch from tonytung-morphology to master November 13, 2019 17:37
This results in a binary mask with zero masks.  Verify that this isn't a corner case that doesn't work.

Test plan: this is the test.
Depends on #1631
@ttung ttung force-pushed the tonytung-empty-label-array branch from afd6797 to 5a4ed4a Compare November 13, 2019 18:58
@ttung ttung merged commit 53e5c01 into master Nov 13, 2019
@ttung ttung deleted the tonytung-empty-label-array branch November 13, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants