-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composed +discriminator models, use dynamic base classes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
Composed schema dynamic base classes
Composed +discriminator models, use dynamic base classes
Jul 9, 2020
Closing this because incorporating this concept is moving forward in OpenAPITools/openapi-generator#8325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPITools/openapi-generator#6797
This above different PR allows composed schemas to return instances of self composed schema None, or int. We enable mixed type returns in composed schemas in python. But it's painful because our endpoint input arguments for ComposedSchema can be None, int, or ComposedSchema. That requires us to traverse ComposedSchema on the client side when we send a ComposedSchema with None or int input, which takes O(n). An easier implementation which would eliminate that O(n) traversal would be to have all instances of ComposedSchema be type ComposedSchema. That requires wrapping all possible results in that type including None, int, Cat etc. in ComposedSchema.
Use Cases That this will address
Dynamic class inheritance it will allow us to generally solve these use cases:
@sebastien-rosset do you know of any other use cases that should be covered here?
This could be a useful pattern in dynamic languages like python, Ruby etc.
With this pattern, when creating an Animal, the returned instance (Cat or Dog) will always be an instance of and a subclass of Animal.
Examples in our file
Discriminator
OneOf Example
ModelSImple example (inherit from Class that is primitive type with validations)
Inherit from primitive types