Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MASK_NRM to match AMI data #893

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

rcooper295
Copy link
Contributor

Small addition to automatically set up instrument with NRM for NIRISS AMI exposures. Currently it gets set up with CLEARP, e.g.:

Configured simulation instrument for:
    Instrument: NIRISS
    Filter: F430M
    Detector: NIS
    Apername: NIS_AMI1
    Det. Pos.: (46, 41) in subarray
    Image plane mask: None
    Pupil plane mask: CLEARP

This change results in:

Configured simulation instrument for:
    Instrument: NIRISS
    Filter: F430M
    Detector: NIS
    Apername: NIS_AMI1
    Det. Pos.: (46, 41) in subarray
    Image plane mask: None
    Pupil plane mask: MASK_NRM

@pep8speaks
Copy link

Hello @rcooper295, Thank you for submitting the Pull Request !

Line 82:37: E261 at least two spaces before inline comment

If you have not done so, please lint your code in accordance with best practices.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@obi-wan76 obi-wan76 merged commit e22c3b1 into spacetelescope:develop Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants