Couple small fixes to LRS support

[mperrin]

Fixes two small issues missed in recent PR #785.

• makes setup_sim_to_match_file better at inferring LRS slit for the specific case of LRS TACONFIRM exposures
• Fixes a bug which would happen if you set the aperture name to MIRIM_SLIT then tried to set it back to some regular aperture such as MIRIM_FULL, due to the SLIT type apertures in pysiaf not having a defined pixescale.

For testing, an example MIRI LRS TACONFIRM exposure is jw01529001001_03102_00001_mirimage_cal.fits.

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/match_data.py:

Line 1:1: E266 too many leading '#' for block comment
Line 159:45: E203 whitespace before ':'

• In the file webbpsf/tests/test_miri.py:

Line 30:11: E271 multiple spaces after keyword
Line 31:17: E126 continuation line over-indented for hanging indent
Line 38:13: E126 continuation line over-indented for hanging indent
Line 138:1: E302 expected 2 blank lines, found 1
Line 150:28: E225 missing whitespace around operator
Line 157:28: E225 missing whitespace around operator
Line 163:5: E303 too many blank lines (2)
Line 163:31: W291 trailing whitespace
Line 166:28: E225 missing whitespace around operator
Line 175:28: E225 missing whitespace around operator
Line 183:28: E225 missing whitespace around operator
Line 192:31: E226 missing whitespace around arithmetic operator
Line 197:51: E226 missing whitespace around arithmetic operator
Line 200:5: E303 too many blank lines (2)
Line 204:28: E225 missing whitespace around operator
Line 209:28: E225 missing whitespace around operator

• In the file webbpsf/webbpsf_core.py:

Line 303:126: E501 line too long (148 > 125 characters)
Line 390:47: E114 indentation is not a multiple of four (comment)
Line 390:47: E116 unexpected indentation (comment)
Line 729:126: E501 line too long (152 > 125 characters)
Line 732:29: E201 whitespace after '('
Line 756:1: E266 too many leading '#' for block comment
Line 980:126: E501 line too long (133 > 125 characters)
Line 982:57: E225 missing whitespace around operator
Line 986:126: E501 line too long (165 > 125 characters)
Line 994:32: E201 whitespace after '('
Line 1006:126: E501 line too long (145 > 125 characters)
Line 1007:126: E501 line too long (136 > 125 characters)
Line 1008:126: E501 line too long (133 > 125 characters)
Line 1011:24: E271 multiple spaces after keyword
Line 1028:126: E501 line too long (134 > 125 characters)
Line 1046:82: E202 whitespace before ')'
Line 1087:52: E225 missing whitespace around operator
Line 1258:91: E231 missing whitespace after ','
Line 1258:126: E501 line too long (139 > 125 characters)
Line 1445:126: E501 line too long (200 > 125 characters)
Line 1601:126: E501 line too long (131 > 125 characters)
Line 1837:9: E303 too many blank lines (2)
Line 1845:126: E501 line too long (165 > 125 characters)
Line 1868:9: E266 too many leading '#' for block comment
Line 1901:9: E266 too many leading '#' for block comment
Line 1902:9: E266 too many leading '#' for block comment
Line 1942:1: E302 expected 2 blank lines, found 1
Line 1946:5: E303 too many blank lines (2)
Line 1947:26: E201 whitespace after '('
Line 1961:5: E303 too many blank lines (2)
Line 2019:126: E501 line too long (127 > 125 characters)
Line 2044:126: E501 line too long (155 > 125 characters)
Line 2064:17: E126 continuation line over-indented for hanging indent
Line 2206:126: E501 line too long (141 > 125 characters)
Line 2348:36: E225 missing whitespace around operator
Line 2388:5: E303 too many blank lines (2)
Line 2407:5: E303 too many blank lines (2)
Line 2424:13: E265 block comment should start with '# '
Line 2427:13: E265 block comment should start with '# '
Line 2429:13: E265 block comment should start with '# '
Line 2430:13: E265 block comment should start with '# '
Line 2431:13: E265 block comment should start with '# '
Line 2432:9: E265 block comment should start with '# '
Line 2440:24: E225 missing whitespace around operator
Line 2444:65: E226 missing whitespace around arithmetic operator
Line 2601:126: E501 line too long (130 > 125 characters)
Line 2645:126: E501 line too long (130 > 125 characters)
Line 2655:126: E501 line too long (141 > 125 characters)
Line 2679:126: E501 line too long (130 > 125 characters)
Line 2705:31: E225 missing whitespace around operator
Line 2919:23: E272 multiple spaces before keyword
Line 3028:126: E501 line too long (134 > 125 characters)
Line 3094:33: E116 unexpected indentation (comment)
Line 3125:33: E221 multiple spaces before operator
Line 3195:71: E231 missing whitespace after ','
Line 3196:126: E501 line too long (145 > 125 characters)
Line 3200:9: E303 too many blank lines (2)
Line 3209:5: E303 too many blank lines (2)
Line 3225:126: E501 line too long (139 > 125 characters)
Line 3240:126: E501 line too long (145 > 125 characters)
Line 3241:126: E501 line too long (137 > 125 characters)
Line 3254:126: E501 line too long (142 > 125 characters)
Line 3262:126: E501 line too long (134 > 125 characters)
Line 3265:43: E261 at least two spaces before inline comment
Line 3268:5: E303 too many blank lines (2)
Line 3299:24: E225 missing whitespace around operator
Line 3321:5: E303 too many blank lines (2)

Comment last updated at 2024-05-20 12:24:33 UTC

[obi-wan76]

Looks good, works as intended.