Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame zero in saturation correction - Roman does not have zero frame #89

Merged
merged 1 commit into from
May 19, 2022

Conversation

nden
Copy link
Collaborator

@nden nden commented May 18, 2022

This is a follow-up on #81 - adds a guard for "frame zero" , since Roman does not have one.

@nden nden changed the title Roman does not have zero frame Frame zero in saturation correction - Roman does not have zero frame May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #89 (3f39c1d) into main (6f2dba7) will increase coverage by 18.46%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #89       +/-   ##
===========================================
+ Coverage   71.66%   90.13%   +18.46%     
===========================================
  Files          16       16               
  Lines        2432     2433        +1     
===========================================
+ Hits         1743     2193      +450     
+ Misses        689      240      -449     
Impacted Files Coverage Δ
src/stcal/ramp_fitting/ramp_fit.py 96.66% <100.00%> (+44.98%) ⬆️
src/stcal/ramp_fitting/gls_fit.py 63.36% <0.00%> (+2.22%) ⬆️
src/stcal/dark_current/dark_sub.py 84.42% <0.00%> (+2.45%) ⬆️
src/stcal/ramp_fitting/utils.py 98.50% <0.00%> (+17.91%) ⬆️
src/stcal/ramp_fitting/ols_fit.py 93.90% <0.00%> (+21.11%) ⬆️
src/stcal/jump/twopoint_difference.py 99.17% <0.00%> (+21.48%) ⬆️
src/stcal/dark_current/dark_class.py 100.00% <0.00%> (+30.95%) ⬆️
src/stcal/jump/constants.py 100.00% <0.00%> (+71.42%) ⬆️
src/stcal/dynamicdq.py 100.00% <0.00%> (+72.72%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2dba7...3f39c1d. Read the comment docs.

@nden nden requested review from hbushouse and ddavis-stsci May 18, 2022 22:50
@nden
Copy link
Collaborator Author

nden commented May 18, 2022

This is ready

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget the change log!

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to run ramp fit on Roman data with this change!

@nden nden merged commit dff7745 into spacetelescope:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants