Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gwcs dependency to released version, update other dependencies (to allow minimum deps to pass) #328

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Dec 19, 2024

Now that gwcs 0.22.0 is out we can remove the development dependency.

This updates the dependencies to use the new gwcs.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review December 19, 2024 20:14
@braingram braingram requested a review from a team as a code owner December 19, 2024 20:14
@braingram braingram changed the title update dependencies remove gwcs dev dependency, update other dependencies Dec 19, 2024
@braingram braingram changed the title remove gwcs dev dependency, update other dependencies update gwcs dependency to released version, update other dependencies (to allow minimum deps to pass) Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.69%. Comparing base (728b877) to head (8f0186b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   29.56%   28.69%   -0.87%     
==========================================
  Files          37       31       -6     
  Lines        8332     7821     -511     
==========================================
- Hits         2463     2244     -219     
+ Misses       5869     5577     -292     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tapastro tapastro merged commit d84b415 into spacetelescope:main Dec 20, 2024
24 of 27 checks passed
@braingram braingram deleted the update_deps branch December 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants