Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fillval option to gwcs_blot #291

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

melanieclarke
Copy link
Contributor

@melanieclarke melanieclarke commented Sep 23, 2024

Currently the gwcs_blot function always fills missing data with 0.0. JWST data uses NaN as the missing value filler for resample by default, so it would be nice to be able to set NaN as the missing value for blotted images too. This PR just adds the option, defaulting to the existing value of 0.0.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@melanieclarke melanieclarke requested a review from a team as a code owner September 23, 2024 20:40
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (3b924fb) to head (8988d2c).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   84.74%   84.76%   +0.02%     
==========================================
  Files          44       44              
  Lines        8527     8542      +15     
==========================================
+ Hits         7226     7241      +15     
  Misses       1301     1301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@melanieclarke
Copy link
Contributor Author

This is internal to stcal, not yet used elsewhere, so I will go ahead and merge.

@melanieclarke melanieclarke merged commit 4ba7a62 into spacetelescope:main Sep 24, 2024
24 of 26 checks passed
@melanieclarke melanieclarke deleted the blot_fillval branch September 24, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants