-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-155] build with Numpy 2.0 release candidate #260
[SCSB-155] build with Numpy 2.0 release candidate #260
Conversation
numpy>=2.0.0rc2
in build-system.requires
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 85.18% 83.73% -1.46%
==========================================
Files 35 35
Lines 6797 6990 +193
==========================================
+ Hits 5790 5853 +63
- Misses 1007 1137 +130 ☔ View full report in Codecov by Sentry. |
Thanks for opening this PR! @zacharyburnett I pushed a change to this PR renaming the now missing |
JWST regtest running against this branch at https://github.com/spacetelescope/RegressionTests/actions/runs/9350842575/job/25735604033 |
I started roman regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/803/ |
the GHA JWST test had some errors, but I'm not sure if those are due to unresolved issues in the GHA or this PR, so I ran on Jenkins here: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2913/pipeline |
are these failures relevant? https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2913/tests |
I don't think so. They match the ones from the previous run (which used stcal main): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
resolves SCSB-155
Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as
1.26
this PR pins
numpy>=2.0.0rc2
inbuild-system.requires
Note
this PR was generated automatically by
batchpr
🤖Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)