JP-2944: Limit major axis expansion for MIRI shower flagging

[mwregan2]

Resolves JP-2944

This PR addresses the fact that the new expansion of the shower ellipses in the JUMP step increases both the major and minor axis of the ellipse by the same relative factor. The change is to instead increase both axes by the same number of pixels. The new code changes the expansion along the major axis to be the same number of pixels as along the minor axis.

Checklist

• added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)

[codecov]

Codecov Report

Base: 70.53% // Head: 70.45% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (45123ec) compared to base (dc44c77).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 45123ec differs from pull request most recent head 0e722e6. Consider uploading reports for the commit 0e722e6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   70.53%   70.45%   -0.09%     
==========================================
  Files          15       15              
  Lines        2620     2623       +3     
==========================================
  Hits         1848     1848              
- Misses        772      775       +3     

Impacted Files	Coverage Δ
src/stcal/jump/jump.py	15.56% <0.00%> (-0.29%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hbushouse]

@mwregan2 Remind me: is this shower flagging still turned off by default in operations processing (like snowball flagging), hence it only affects off-line work?

[hbushouse]

Are any doc updates needed for this?

Also, we're closing in on trying to get our next (probably last) B9.0 release candidate out the door (either later today or Monday). Is this ready to go or do you want to do more work/testing on it yet?

[mwregan2]

Howard, It doesn’t require any documentation updates and it is performing as I expected. Shower and Snowball flagging are controlled by the flag_large_events parameter which is set to False by default. Mike From: Howard Bushouse ***@***.***> Reply-To: spacetelescope/stcal ***@***.***> Date: Friday, October 14, 2022 at 1:52 PM To: spacetelescope/stcal ***@***.***> Cc: Michael Regan ***@***.***>, Mention ***@***.***> Subject: Re: [spacetelescope/stcal] JP-2944: Limit major axis expansion for MIRI shower flagging (PR #123) Are any doc updates needed for this? Also, we're closing in on trying to get our next (probably last) B9.0 release candidate out the door (either later today or Monday). Is this ready to go or do you want to do more work/testing on it yet? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/spacetelescope/stcal/pull/123*issuecomment-1279299898__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!zsbMmbEdsO_MLn2xnZYnE8nKdhQtqV2tRDHPepu9TCf5zAvPogDiPn0P8xobKXt-PXulMLrbBDEtIzKtDIiOP1c$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF6KJLX2PEIQD344YZQORNLWDGMXFANCNFSM6AAAAAARCOO3RA__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!zsbMmbEdsO_MLn2xnZYnE8nKdhQtqV2tRDHPepu9TCf5zAvPogDiPn0P8xobKXt-PXulMLrbBDEtIzKtsst-HLg$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[hbushouse]

OK, thanks @mwregan2. I will go ahead and merge this, so that we can get both stcal and jwst releases out the door for B9.0rc2.