JP-1950: Bug fix for DQ flags #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uppression. Also, made changes to fix the bug in JP-1950, where 'shifting' was happening twice.
dmggh
previously approved these changes
May 18, 2021
jdavies-st
reviewed
May 18, 2021
src/stcal/ramp_fitting/ols_fit.py
Outdated
| @@ -1597,10 +1597,8 @@ def calc_slope(data_sect, gdq_sect, frame_time, opt_res, save_opt, rn_sect, | |||
| err_2d_array = data_sect[0, :, :] * frame_time | |||
|
|
|||
| # Suppress, then re-enable, harmless arithmetic warnings | |||
| ''' | |||
There was a problem hiding this comment.
You could use Numpy's errstate context manager here:
with np.errstate(divide="ignore", invalid="ignore"):
err_2d_array[err_2d_array < 0] = 0But that's just a more concise way of doing the same thing.
The current error/warning global config for numpy can be grabbed via np.geterr().
There was a problem hiding this comment.
The question is why is e.g. divide by zero filtered out. Is there a chance it's going to be raised?
But since this is not related to the current bug being fixed I suggest if necessary it can be changed in another PR.
There was a problem hiding this comment.
I removed the code changes not directly related to the bug in JP-1950.
|
👍 merging after a change log is added. |
nden
approved these changes
May 19, 2021
5 tasks
jdavies-st
pushed a commit
to spacetelescope/jwst
that referenced
this pull request
May 20, 2021
* Updating test cases for the bug fix done in spacetelescope/stcal#12 * bump install_requires and requirements-sdp.txt for stcal 0.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to fix the computation of the median of the first differences of a ramp. Because there is one less difference than there are groups a "shift" is needed to make sure the correct data quality flag is applied. This "shifting" was incorrectly done twice, when it should have only been done once.
Fixes JP-1950
Fixes spacetelescope/jwst#3879