RCAL-362 Fix Tvac Filename Node Type #368
Conversation
for more information, see https://pre-commit.ci
…oman_datamodels into RCAL-879_TVACFilename
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 97.56% 97.69% +0.13%
==========================================
Files 30 37 +7
Lines 2788 3379 +591
==========================================
+ Hits 2720 3301 +581
- Misses 68 78 +10 ☔ View full report in Codecov by Sentry. |
|
Is there any documentation on these TVAC and FPS models/nodes and their relationship to the typical models and nodes used by romancal? Specifically, is it expected that running some (or all) romancal steps should be possible with these models? Is the expected output for a step run with TVAC data (for example) another TVAC model or a standard model (perhaps with some extra TVAC metadata)? |
| @@ -206,8 +227,19 @@ def __getattr__(self, key): | |||
|
|
|||
| # If the key is in the schema, then we can return the value | |||
| if key in self._data: | |||
| if (".Tvac" in str(type(self._parent))) or ( | |||
| str(type(self._data[key])).split(".")[-1].split("'")[0] in TVAC_SCALAR_NODES | |||
There was a problem hiding this comment.
It looks like there is a lot going on in these lines of code. What's the goal?
|
Superseded by work in #369 |
Resolves RCAL-362
Closes #362
This PR preserves Tvac & FPS tagged scalar node types.
Checklist
CHANGES.rstunder the corresponding subsection