Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-831: Add statistics field to TVAC and FPS Models #351

Merged
merged 5 commits into from
May 14, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented May 12, 2024

Resolves RCAL-831

Closes #

This PR adds statistics blocks to the TVAC and FS models.

Checklist

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (087a60d) to head (181671a).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   97.56%   97.52%   -0.05%     
==========================================
  Files          30       37       +7     
  Lines        2788     3347     +559     
==========================================
+ Hits         2720     3264     +544     
- Misses         68       83      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review May 12, 2024 22:54
@PaulHuwe PaulHuwe requested a review from a team as a code owner May 12, 2024 22:54
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PaulHuwe PaulHuwe merged commit 09b8435 into spacetelescope:main May 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants