-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-824: Separate TVAC and FPS Models and Makers from Main #347
Conversation
for more information, see https://pre-commit.ci
…an_datamodels into RCAL-824_SepTVACFPS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
===========================================
- Coverage 97.56% 78.92% -18.64%
===========================================
Files 30 37 +7
Lines 2788 3340 +552
===========================================
- Hits 2720 2636 -84
- Misses 68 704 +636 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Added passed Reg tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Needs a rebase before merging.
for more information, see https://pre-commit.ci
…an_datamodels into RCAL-824_SepTVACFPS
Resolves RCAL-824
Closes #
This PR creates a suite of separate TVAC and FPS makers to freeze them and keep them separate from main development.
Checklist
CHANGES.rst
under the corresponding subsection