Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-824: Separate TVAC and FPS Models and Makers from Main #347

Merged
merged 17 commits into from
May 9, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented May 1, 2024

Resolves RCAL-824

Closes #

This PR creates a suite of separate TVAC and FPS makers to freeze them and keep them separate from main development.

Checklist

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 36.71642% with 212 lines in your changes are missing coverage. Please review.

Project coverage is 78.92%. Comparing base (087a60d) to head (5c3d856).
Report is 20 commits behind head on main.

❗ Current head 5c3d856 differs from pull request most recent head ad109f5. Consider uploading reports for the commit ad109f5 to get more accurate results

Files Patch % Lines
...c/roman_datamodels/maker_utils/_fps_common_meta.py 12.85% 61 Missing ⚠️
.../roman_datamodels/maker_utils/_tvac_common_meta.py 12.85% 61 Missing ⚠️
src/roman_datamodels/maker_utils/_fps.py 28.33% 43 Missing ⚠️
...rc/roman_datamodels/maker_utils/_fps_basic_meta.py 50.00% 15 Missing ⚠️
...c/roman_datamodels/maker_utils/_tvac_basic_meta.py 50.00% 15 Missing ⚠️
src/roman_datamodels/maker_utils/_tvac.py 82.75% 5 Missing ⚠️
src/roman_datamodels/stnode/_factories.py 50.00% 4 Missing ⚠️
src/roman_datamodels/stnode/_converters.py 25.00% 3 Missing ⚠️
src/roman_datamodels/stnode/_node.py 70.00% 3 Missing ⚠️
src/roman_datamodels/stnode/_tagged.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #347       +/-   ##
===========================================
- Coverage   97.56%   78.92%   -18.64%     
===========================================
  Files          30       37        +7     
  Lines        2788     3340      +552     
===========================================
- Hits         2720     2636       -84     
- Misses         68      704      +636     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review May 1, 2024 02:19
@PaulHuwe PaulHuwe requested a review from a team as a code owner May 1, 2024 02:19
@PaulHuwe PaulHuwe requested a review from nden May 3, 2024 16:22
@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented May 3, 2024

Added passed Reg tests.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Needs a rebase before merging.

@PaulHuwe PaulHuwe merged commit 52d2b96 into spacetelescope:main May 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants