Fix dependency to be consistent with romancal #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
zacharyburnett
approved these changes
Oct 11, 2023
6 tasks
|
Ah, thanks for the catch. LGTM |
PaulHuwe
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exact branch of
radis specified by this project. Unfortunately, this conflicts with the specification for dev dependencies inromancal, that isromancaldoes not have an@maindecoration. This means that when attempting to install this version ofroman_datamodelsusing the dev dependencies forromancalan "version conflict" occurs; meaning that none of the regression tests will even install properly.Checklist
CHANGES.rstunder the corresponding subsection