Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __repr__ for DNode objects. #245

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 19, 2023

PR #191 accidentally removed the __repr__ for DNode based objects. This PR adds this back along with a test for this.

Fixes #244
Fixes #246

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 19, 2023 16:25
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7b5f02f) 96.74% compared to head (4fd3a42) 96.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files          29       28    -1     
  Lines        2398     2398           
=======================================
  Hits         2320     2320           
  Misses         78       78           
Impacted Files Coverage Δ
src/roman_datamodels/stnode/_node.py 88.75% <100.00%> (+0.14%) ⬆️
tests/test_stnode.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

@WilliamJamieson WilliamJamieson merged commit 3a508ff into spacetelescope:main Jul 20, 2023
@WilliamJamieson WilliamJamieson deleted the feature/node_repr branch July 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add inline data representations Metadata display
2 participants