Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding source detection #132

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

cshanahan1
Copy link
Collaborator

@cshanahan1 cshanahan1 commented Mar 16, 2023

(This PR is replacing #124)

Adds a schema for meta.source_detection. This contains an optional string path to a source catalog TweakReg.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (caaad94) 97.16% compared to head (5c098c0) 97.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files           8        8           
  Lines         810      810           
=======================================
  Hits          787      787           
  Misses         23       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cshanahan1 cshanahan1 force-pushed the source_detection_new branch from 7310b68 to f8de2e6 Compare March 17, 2023 17:24
@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Mar 23, 2023

rebased against main to include CI updates

@zacharyburnett
Copy link
Collaborator

looks like tests are all green now, that's odd

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cshanahan1 cshanahan1 merged commit 36b556e into spacetelescope:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants