Initial Association datamodel support. #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHuwe
requested review from
ddavis-stsci,
perrygreenfield,
nden,
WilliamJamieson and
sosey
|
If I understand this correctly, there is some sort of json file which gets read to create the |
Codecov ReportBase: 70.31% // Head: 71.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 70.31% 71.12% +0.80%
==========================================
Files 15 15
Lines 2139 2192 +53
==========================================
+ Hits 1504 1559 +55
+ Misses 635 633 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The method to input via json model isn't coded yet (that is ticket RCAL-395) - there is merely a placeholder comment until that functionality is implemented. |
mairanteodoro
requested review from
mairanteodoro
and removed request for
mairanteodoro
mairanteodoro
added a commit
to mairanteodoro/roman_datamodels
that referenced
this pull request
Feb 1, 2023
mairanteodoro
added a commit
that referenced
this pull request
Mar 1, 2023
* Initial test. * Rename model container class; add support for list * Refactored ModelContainer to use __getitem__ on list input. * Added tests for ModelContainer. * Implement additional magic methods and use temp RAD for testing. * Temp fix for RAD. * freeze action versions (#85) * freeze action versions * Apply suggestions from code review Co-authored-by: William Jamieson <wjamieson@stsci.edu> Co-authored-by: William Jamieson <wjamieson@stsci.edu> * freeze action versions (#85) * freeze action versions * Apply suggestions from code review Co-authored-by: William Jamieson <wjamieson@stsci.edu> Co-authored-by: William Jamieson <wjamieson@stsci.edu> * Revert RAD install required to default. * Add code from PR #102 (RCAL-386). * Remove Associations class from model registry. * Remove ModelContainer class from model registry. * Add Associations class to model registry and expose it. * Add Associations class to stnode.py. * Add empty tag attribute to Associations class. * Change Associations._tag type from None to empty string. * Remove __init__ method from Associations class. * Set tag to empty string in Associations class. * Remove Associations class from model registry. * Expose AssociationModel and create getter/setter for Associations class. * Change RAD lib version. * Bug fix. * Use temp RAD. * Class and methods clean up. * Remove pop method from ModelContainer. * Fix code style issues. * Revert RAD to main. * Revert RAD to main. * Remove references to Associations. * Fix ModelContainer tests. * Clean up. * Code style fix. * Fix code style issues using pre-commit hooks. * Add Associations class & tests from PR #101. * Point RAD to main. * Code style fixes and class clean up. * Add unit tests for ImageModel. * Remove unnecessary magic methods. * Fix issues with docstrings. * Update docstring description. * Remove outdated unit test. --------- Co-authored-by: PaulHuwe <phuwe@stsci.edu> Co-authored-by: Zach Burnett <zburnett@stsci.edu> Co-authored-by: William Jamieson <wjamieson@stsci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.. this is an initial take on a data model support for associations. This is a companion ticket to the schema ticket:
spacetelescope/rad#162
I am opening this in draft PR to facilitate conversation.