-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-911 & 932: remove units from MOS and ELP pipelines. #485
RCAL-911 & 932: remove units from MOS and ELP pipelines. #485
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 4 4
Lines 215 215
=======================================
Hits 206 206
Misses 9 9 ☔ View full report in Codecov by Sentry. |
e1356b1
to
379fc9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only a few minor unit doc suggestions.
Resolves RCAL-911
Resolves RCAL-932
This PR modifies several files so that units are not used anymore.
The information about units is still retained in the RAD schema.
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/485.removal.rst
: Remove units from rad schema.