Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-911 & 932: remove units from MOS and ELP pipelines. #485

Conversation

mairanteodoro
Copy link
Contributor

@mairanteodoro mairanteodoro commented Oct 16, 2024

Resolves RCAL-911
Resolves RCAL-932

This PR modifies several files so that units are not used anymore.
The information about units is still retained in the RAD schema.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/485.removal.rst: Remove units from rad schema.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (810c17f) to head (267d9e1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           4        4           
  Lines         215      215           
=======================================
  Hits          206      206           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mairanteodoro mairanteodoro force-pushed the RCAL-932-remove-units-in-exposure-level-pipeline branch from e1356b1 to 379fc9a Compare October 16, 2024 17:53
@mairanteodoro mairanteodoro marked this pull request as ready for review October 16, 2024 17:55
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only a few minor unit doc suggestions.

src/rad/resources/schemas/sky_background-1.0.0.yaml Outdated Show resolved Hide resolved
src/rad/resources/schemas/wfi_image-1.0.0.yaml Outdated Show resolved Hide resolved
src/rad/resources/schemas/wfi_image-1.0.0.yaml Outdated Show resolved Hide resolved
src/rad/resources/schemas/wfi_image-1.0.0.yaml Outdated Show resolved Hide resolved
src/rad/resources/schemas/wfi_image-1.0.0.yaml Outdated Show resolved Hide resolved
src/rad/resources/schemas/wfi_image-1.0.0.yaml Outdated Show resolved Hide resolved
@PaulHuwe PaulHuwe merged commit 974d82f into spacetelescope:main Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants