Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test with python 3.13 #468

Merged
merged 2 commits into from
Oct 28, 2024
Merged

test with python 3.13 #468

merged 2 commits into from
Oct 28, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 8, 2024

This PR adds python 3.13 to the CI. As it shows no errors the changelog says we support python 3.13

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (810c17f) to head (0b4dc53).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           4        4           
  Lines         215      215           
=======================================
  Hits          206      206           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review October 8, 2024 18:22
@braingram braingram requested a review from a team as a code owner October 8, 2024 18:22
@braingram braingram changed the title test python 3.13 test with python 3.13 Oct 8, 2024
@braingram braingram requested a review from PaulHuwe October 8, 2024 18:27
@PaulHuwe PaulHuwe merged commit da7e04e into spacetelescope:main Oct 28, 2024
12 checks passed
@braingram braingram deleted the py313 branch October 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants