Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-176: Add ref_file entry for reference pixel subtraction reference file #458

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Oct 3, 2024

Resolves RAD-176

Closes #431 #457

This PR adds ref_file entry for reference pixel subtraction reference file.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (810c17f) to head (d66d648).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           4        4           
  Lines         215      215           
=======================================
  Hits          206      206           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe merged commit fe9c909 into spacetelescope:main Oct 11, 2024
13 checks passed
@PaulHuwe PaulHuwe deleted the RAD-176_RefPixRefFile branch October 11, 2024 02:28
mairanteodoro pushed a commit to mairanteodoro/rad that referenced this pull request Oct 16, 2024
… file (spacetelescope#458)

* Initial commit.

* Added changelog.

* Fix for rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ref_file entry for reference pixel subtraction reference file
3 participants