Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-171: Add statistics field to TVAC and FPS schemas #423

Merged
merged 4 commits into from
May 14, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented May 12, 2024

Resolves RAD-171

Closes #412

This PR adds a statistics schema to both FPS and TVAC.

Checklist

@PaulHuwe PaulHuwe marked this pull request as ready for review May 12, 2024 22:46
@PaulHuwe PaulHuwe requested a review from a team as a code owner May 12, 2024 22:46
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (c1811ab) to head (820dd8d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           4        4              
  Lines         195      198       +3     
==========================================
+ Hits          186      189       +3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@fjaviersanchez fjaviersanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

@PaulHuwe PaulHuwe merged commit c9d7381 into spacetelescope:main May 14, 2024
3 of 6 checks passed
@PaulHuwe PaulHuwe deleted the RAD-171_TVACFPSStats branch May 14, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add statistics field to TVAC and FPS schemas
4 participants