-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAD-165: Separate TVAC and FPS Schemas from Main #414
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 95.38% 95.45% +0.06%
==========================================
Files 4 4
Lines 195 198 +3
==========================================
+ Hits 186 189 +3
Misses 9 9 ☔ View full report in Codecov by Sentry. |
…into RAD-165_SepTVACFPS
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only question I had was the archive catalog destinations being a superset, but I see you're handling those updates as a future ticket. No other concerns from me.
Looks good to me. |
Still needed. |
It looks like there's a lot of duplicated data between the fps and tvac folders. Can any of those files be shared between the two? I understand that you don't want to share with science data since the science schemas are in flux, but does that problem exist at the individual test level as well? |
You've left references to ScienceRefData and GuideWindow tables in the tvac and fps files. We don't have ScienceRefData for RITA (it's stored in WFICommon. We don't have GuideWindow for RITA (my understanding is we don't have GuideWindows for test data). |
Will the RITA schemas always be isolated from the Roman schemas? If yes, maybe Tim @relaxing could make use of the archive_meta tag (currently set to None) to distinguish Roman from RITA? |
It was decided to freeze TVAC and FPS individually, which means we need to keep the duplicates. |
This sounds good to me.. do you want to discuss it at a RAD meeting, or just have @relaxing implement it as it is an archive only keyword? |
Resolves RAD-165
Closes #407
This PR creates a suite of separate TVAC and FPS schemas to freeze them and keep them separate from main development. NOTE: archive catalog targets need updating, which I will split out into another ticket.
Checklist
CHANGES.rst
under the corresponding subsection