Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-161: Bit Mask to Resample #401

Merged
merged 8 commits into from
Apr 4, 2024
Merged

RAD-161: Bit Mask to Resample #401

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
daa79ad
Initial commit.
PaulHuwe Apr 1, 2024
ea9fed0
Updated Changelog.
PaulHuwe Apr 1, 2024
dd09ca6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2024
8153b42
Added outlier detection group and good_bits.
PaulHuwe Apr 3, 2024
5e765a0
Rebased.
PaulHuwe Apr 3, 2024
88ddcba
Rebased.
PaulHuwe Apr 3, 2024
1925db6
Update Changelog.
PaulHuwe Apr 3, 2024
4911a2f
Removed outlier_detection from wfi_mosaic.
PaulHuwe Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGES.rst
View file
Open in desktop
PaulHuwe marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,12 @@

- Create the flux step schema. [#395]

- Add bit mask field to ``resample``. [#401]

- Add source_catalog and segmentation_map schemas for Level 2 and Level 3 files. [#393]

0.19.0 (2024-02-09)

0.19.0 (2024-02-09)
-------------------

- Added streamlined Level 3 Mosaic metadata schemas. [#334]
Expand Down
5 changes: 5 additions & 0 deletions src/rad/resources/manifests/datamodels-1.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ tags:
title: Level 3 Calibration Step status information
description: |-
Level 3 Calibration Step status information
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/outlier_detection-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/outlier_detection-1.0.0
title: Outlier Detection information
description: |-
Outlier Detection information
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/resample-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/resample-1.0.0
title: Resample information
Expand Down
17 changes: 17 additions & 0 deletions src/rad/resources/schemas/outlier_detection-1.0.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
%YAML 1.1
---
$schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0
id: asdf://stsci.edu/datamodels/roman/schemas/outlier_detection-1.0.0

title: Outlier Detection Information
type: object
properties:
good_bits:
title: Bit Mask
description: |
Bit mask parameter sent to resample.
type: string
propertyOrder: [good_bits]
flowStyle: block
required: [good_bits]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure I understand---good_bits is required if outiler_detection is specified, but outlier_detection is not required in wfi_image. I think that's what you've written and that sounds right to me, but just checking!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, that is what I intended with my implementation.

...
9 changes: 7 additions & 2 deletions src/rad/resources/schemas/resample-1.0.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ id: asdf://stsci.edu/datamodels/roman/schemas/resample-1.0.0
title: Resample Information
type: object
properties:
good_bits:
title: Bit Mask
description: |
Bit mask used in resample.
type: string
pixel_scale_ratio:
title: Pixel Scale Ratio
description: |
Expand Down Expand Up @@ -44,7 +49,7 @@ properties:
variance map ("ivm").
type: string
enum: ["exptime", "ivm"]
propertyOrder: [members, pixel_scale_ratio, pixfrac, pointings, product_exposure_time, weight_type]
propertyOrder: [good_bits, members, pixel_scale_ratio, pixfrac, pointings, product_exposure_time, weight_type]
flowStyle: block
required: [members, pixel_scale_ratio, pixfrac, weight_type]
required: [good_bits, members, pixel_scale_ratio, pixfrac, weight_type]
...
2 changes: 2 additions & 0 deletions src/rad/resources/schemas/wfi_image-1.0.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ properties:
- type: "null"
photometry:
tag: asdf://stsci.edu/datamodels/roman/tags/photometry-1.0.0
outlier_detection:
tag: asdf://stsci.edu/datamodels/roman/tags/outlier_detection-1.0.0
source_detection:
tag: asdf://stsci.edu/datamodels/roman/tags/source_detection-1.0.0
required: [photometry, wcs]
Expand Down
2 changes: 2 additions & 0 deletions src/rad/resources/schemas/wfi_mosaic-1.0.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ properties:
tag: asdf://stsci.edu/datamodels/roman/tags/coordinates-1.0.0
individual_image_meta:
tag: asdf://stsci.edu/datamodels/roman/tags/individual_image_meta-1.0.0
outlier_detection:
tag: asdf://stsci.edu/datamodels/roman/tags/outlier_detection-1.0.0
photometry:
tag: asdf://stsci.edu/datamodels/roman/tags/photometry-1.0.0
program:
Expand Down