RAD-149: Split cal_step into L2 & L3 #397
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 4 4
Lines 195 195
=======================================
Hits 186 186
Misses 9 9 ☔ View full report in Codecov by Sentry. |
|
NOTE: these changes require updates to romancal regression test files as shown in the Jenkins URL. |
PaulHuwe
requested review from
kdupriestsci,
jbrookens and
a team
as code owners
| archive_catalog: | ||
| datatype: nvarchar(15) | ||
| destination: [ScienceRefData.s_resample, GuideWindow.s_resample, WFICommon.s_resample] | ||
| propertyOrder: [outlier_detection, skymatch, resample] |
There was a problem hiding this comment.
Can we also add the flux step to the l3 cal_steps?
There was a problem hiding this comment.
Sure, will be sure to merge the flux tickets first then do that. Should it only be in L3, or in both?
There was a problem hiding this comment.
It is the first step in the l3 pipeline, so i think it should only be in the l3 headers.
There was a problem hiding this comment.
flux is like outlier detection & sky matching in that it's done on L2 "intermediate" images, so we'd be marking it done on the L2 image models and then propagating that into the L3 image. i.e., it goes into the L2 and L3 cal_step dictionary.
There was a problem hiding this comment.
I thought that in Roman all of the r_ and s_ fields went in ScienceRefData and GuideWindow. Why are the 3 fields in this file going in WFIMosaic?
Also, will these fields appear in any of the RITA files?
Resolves RAD-149
Closes #363
This PR splits the cal_step schema into L2 and L3 versions.
Checklist
CHANGES.rstunder the corresponding subsection