-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAD-139: Add Members Keyword to Resample Schema #396
RAD-139: Add Members Keyword to Resample Schema #396
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 4 4
Lines 195 195
=======================================
Hits 186 186
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Do we expect the members to already be included as individual_image_meta.basic.filename? It is good to include this somewhere, and we aren't currently populating individual_image_meta.basic.filename, but once is probably enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Yes, I would expect this information to be in |
Okay, fine to duplicate this. |
Resolves RAD-139
Closes #340
This PR adds the members keyword to the resample schema.
Checklist
CHANGES.rst
under the corresponding subsection