Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to sphinx-rtd-theme #378

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

braingram
Copy link
Collaborator

To match the theme used for romancal:
https://github.com/spacetelescope/romancal/blob/6417cf25b0dea81063041c69e470198152282d7a/pyproject.toml#L47

This PR switches the docs sphinx theme to sphinx-rtd-theme.

Checklist

@braingram braingram marked this pull request as ready for review February 26, 2024 15:44
@braingram braingram requested a review from a team as a code owner February 26, 2024 15:44
@braingram
Copy link
Collaborator Author

I am unable to add labels to this PR so cannot add no-changelog-entry-needed.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -31,7 +31,7 @@ you should have a clear idea of the following:

* Which fields will be primitive data types like ``int``, ``float``,
``str``, or ``bool``. In JSON-schema these will be ``integer``,
``number``, ``string``, and ``boolean`` respectively.
``number``, ``string``, and ``boolean`` respectively.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this indentation was causing a warning during the docs build:
/home/docs/checkouts/readthedocs.org/user_builds/rad/checkouts/364/docs/creating.rst:34: ERROR: Unexpected indentation.
See: https://readthedocs.org/api/v2/build/23542081.txt

@braingram
Copy link
Collaborator Author

Thanks @schlafly for the review. I am also unable to merge this PR so feel free to merge it whenever it's convenient.

@braingram braingram mentioned this pull request Feb 26, 2024
4 tasks
@nden nden merged commit 7337c3d into spacetelescope:main Feb 26, 2024
11 of 12 checks passed
@nden nden added this to the Build 14 milestone Feb 26, 2024
@braingram braingram deleted the sphinx_rtd branch February 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants