-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAD-148: Require exact datatypes for ndarrays #369
RAD-148: Require exact datatypes for ndarrays #369
Conversation
def test_exact_datatype(schema): | ||
"""Confirm that `exact_datatype` is defined for all arrays""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This confirms that exact_datatype
is defined for all ndarrays.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 95.32% 95.38% +0.06%
==========================================
Files 4 4
Lines 171 195 +24
==========================================
+ Hits 163 186 +23
- Misses 8 9 +1 ☔ View full report in Codecov by Sentry. |
There were a few errors in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ada9b18
to
db2a02b
Compare
for example RAD-1234: -->
Resolves RAD-148
Closes #353
Require exact datatype for ndarrays. This means that ASDF will not attempt to make any type casting when saving files, so all types are explicitly defined in the romancal code.
Checklist
CHANGES.rst
under the corresponding subsection