Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-148: Require exact datatypes for ndarrays #369

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Feb 6, 2024

for example RAD-1234: -->
Resolves RAD-148

Closes #353

Require exact datatype for ndarrays. This means that ASDF will not attempt to make any type casting when saving files, so all types are explicitly defined in the romancal code.

Checklist

Comment on lines +222 to +220
def test_exact_datatype(schema):
"""Confirm that `exact_datatype` is defined for all arrays"""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confirms that exact_datatype is defined for all ndarrays.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e85f964) 95.32% compared to head (db2a02b) 95.38%.

Files Patch % Lines
tests/test_schemas.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   95.32%   95.38%   +0.06%     
==========================================
  Files           4        4              
  Lines         171      195      +24     
==========================================
+ Hits          163      186      +23     
- Misses          8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson
Copy link
Collaborator Author

There were a few errors in romancal unit tests with no regression test failures. The fixes for romancal are in spacetelescope/romancal#1090 and these fixes are independent of the changes here. To avoid any confusion the regression tests were run with the changes from 1090 so that there were no failures, see https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/592.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review February 6, 2024 21:08
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 950939e into spacetelescope:main Feb 9, 2024
13 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/exact_datatype branch February 9, 2024 20:27
@nden nden added this to the Build 14 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema use of datatype allows safe castable datatypes
4 participants