Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rad 136 dark slope err #324

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Rad 136 dark slope err #324

merged 5 commits into from
Oct 11, 2023

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Oct 10, 2023 •
edited
Loading

This PR is an addendum to RAD-136 in order to remove the err array.

Checklist

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@PaulHuwe PaulHuwe marked this pull request as ready for review October 10, 2023 21:36
@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners October 10, 2023 21:36
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Oct 10, 2023
Closed
ddavis-stsci
ddavis-stsci approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit 0eb0119 into spacetelescope:main Oct 11, 2023
11 checks passed
@PaulHuwe PaulHuwe deleted the RAD-136_DarkSlopeErr branch October 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddavis-stsci ddavis-stsci ddavis-stsci approved these changes

@schlafly schlafly schlafly approved these changes

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulHuwe @schlafly @ddavis-stsci