Add archive_catalog field to ref_file #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nden
requested review from
kdupriestsci and
PaulHuwe
and removed request for
kdupriestsci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 4 4
Lines 171 171
=======================================
Hits 163 163
Misses 8 8 ☔ View full report in Codecov by Sentry. |
PaulHuwe
reviewed
Aug 3, 2023
| dark: | ||
| title: Dark Subtraction | ||
| type: string | ||
| enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE'] | ||
| archive_catalog: | ||
| datatype: nvarchar(15) | ||
| destination: [ScienceRefData.dark, GuideWindow.dark] | ||
| destination: [ScienceRefData.s_dark, GuideWindow.s_dark] |
There was a problem hiding this comment.
Do we want to send every step to GuideWindow, or just dq_init? (Since GuideWindows aren't going through all the steps, so would never have some of these?)
There was a problem hiding this comment.
This was left open for discussion. I think GuideWindow is probably not necessary at all.
kdupriestsci
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RAD-nnnn
Closes #
This PR addresses an issue with archiving the reference files and populating the archive catalog. Previously the
archive_catalogfield was missing from theref_fileschema which caused the names of the files to not be populated in the database. In addition, there's a name collision becausereftypeis used incal_stepandref_file. While this is OK for the science files because they are under different tags, in the archive they go in the same database, and so for exampleref_file.darkandcal_step.darkboth map todark. To resolve the name collision the archive destination names were changed: the ones incal_stepwere prefixed withs, and the ones inref_filewere prefixed withr.Note that these changes do not affect data files and so no changes are needed in roman_datamodels.
Checklist
CHANGES.rstunder the corresponding subsection