Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAD-128 Require new cal_step values #301

Merged
merged 2 commits into from
Aug 3, 2023
Merged

RAD-128 Require new cal_step values #301

merged 2 commits into from
Aug 3, 2023

Conversation

WilliamJamieson
Copy link
Collaborator

Resolves RAD-128

Closes #287

This PR makes all the newly added cal_step steps required.

Checklist

  • Schema changes discussed at RAD Review Board meeting
  • Added entry in CHANGES.rst under the corresponding subsection
  • Updated relevant roman_datamodels utilities and tests
  • Passed romancal regression testing on Jenkins / PLWishMaster. This will break all the regression tests until new files can be generated.

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (f44168b) 95.32% compared to head (1b8c2a2) 95.32%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          163      163           
  Misses          8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PaulHuwe
PaulHuwe approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson force-pushed the feature/require_new_cal_step branch from f66cd5e to 1b8c2a2 Compare August 3, 2023 17:35
@WilliamJamieson WilliamJamieson marked this pull request as ready for review August 3, 2023 17:35
@PaulHuwe PaulHuwe merged commit cc05597 into spacetelescope:main Aug 3, 2023
@WilliamJamieson WilliamJamieson deleted the feature/require_new_cal_step branch August 3, 2023 17:49
@braingram braingram mentioned this pull request Aug 9, 2023
Open
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulHuwe PaulHuwe PaulHuwe approved these changes

@kdupriestsci kdupriestsci Awaiting requested review from kdupriestsci kdupriestsci is a code owner

@jbrookens jbrookens Awaiting requested review from jbrookens jbrookens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make newly added cal-step arguments required
2 participants
@WilliamJamieson @PaulHuwe