-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive_meta keyword #279
Add archive_meta keyword #279
Conversation
@PaulHuwe can you let me know which additional schemas need this keyword. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 4 4
Lines 171 171
=======================================
Hits 163 163
Misses 8 8 ☔ View full report in Codecov by Sentry. |
I believe the only one you are missing is: @kdupriestsci can you confirm, please? To help: |
Agreed. This will need to be added to schemas/guidewindow-1.0.0 as well |
1f458e7
to
451c8c2
Compare
451c8c2
to
a9525f6
Compare
a9525f6
to
20f0df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
46ffe1f
to
1683edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1683edb
to
5a9faf9
Compare
This PR adds an archive_meta keyword to the file-level schemas relevant to the archive. Currently, this keyword does not carry any information other than marking the schemas; however, discussions of how to structure this information are still on-going. This information will be added in follow-on pull requests.
Checklist
CHANGES.rst
under the corresponding subsection