Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive_meta keyword #279

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jun 23, 2023

This PR adds an archive_meta keyword to the file-level schemas relevant to the archive. Currently, this keyword does not carry any information other than marking the schemas; however, discussions of how to structure this information are still on-going. This information will be added in follow-on pull requests.

Checklist

@WilliamJamieson WilliamJamieson requested a review from PaulHuwe June 23, 2023 16:07
@WilliamJamieson
Copy link
Collaborator Author

@PaulHuwe can you let me know which additional schemas need this keyword.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c60038e) 95.32% compared to head (5a9faf9) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          163      163           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe
Copy link
Collaborator

I believe the only one you are missing is:
schemas/guidewindow-1.0.0

@kdupriestsci can you confirm, please? To help:
schemas/wfi_science_raw-1.0.0.yaml -> WFI Level 1
schemas/wfi_image-1.0.0.yaml -> WFI Level 2
schemas/wfi_mosaic-1.0.0.yaml -> WFI Level 3
schemas/guidewindow-1.0.0 -> GuideWindows

@kdupriestsci
Copy link
Collaborator

I believe the only one you are missing is: schemas/guidewindow-1.0.0

@kdupriestsci can you confirm, please? To help: schemas/wfi_science_raw-1.0.0.yaml -> WFI Level 1 schemas/wfi_image-1.0.0.yaml -> WFI Level 2 schemas/wfi_mosaic-1.0.0.yaml -> WFI Level 3 schemas/guidewindow-1.0.0 -> GuideWindows

Agreed. This will need to be added to schemas/guidewindow-1.0.0 as well

@WilliamJamieson WilliamJamieson marked this pull request as ready for review July 27, 2023 17:26
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 97cb9fb into spacetelescope:main Jul 31, 2023
@WilliamJamieson WilliamJamieson deleted the feature/archive_meta branch July 31, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants