Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners file #230

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RAD-nnnn

Closes #

This PR adds Jason to the list of reviewers for changes of the yaml files.

Checklist

  • Schema changes discussed at RAD Review Board meeting
  • Added entry in CHANGES.rst under the corresponding subsection
  • [N/A] Updated relevant roman_datamodels utilities and tests

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ba7c3d9) 93.54% compared to head (bd67618) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           4        4           
  Lines         124      124           
=======================================
  Hits          116      116           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddavis-stsci ddavis-stsci marked this pull request as ready for review April 3, 2023 14:52
@ddavis-stsci ddavis-stsci requested review from a team and WilliamJamieson as code owners April 3, 2023 14:52
@ddavis-stsci ddavis-stsci self-assigned this Apr 3, 2023
@ddavis-stsci ddavis-stsci added the enhancement New feature or request label Apr 3, 2023
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GitHub says the file is valid

# Add Kim, Kimberly DuPrie <kduprie@stsci.edu>
src/rad/resources/schemas/*.yaml @kdupriestsci
# Add Kim, Kimberly DuPrie <kduprie@stsci.edu>, add jbrookens@stsci.edu
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens @WilliamJamieson

you might also want to add @WilliamJamieson , he requested to be notified of schema changes

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kdupriestsci kdupriestsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks.

@ddavis-stsci ddavis-stsci merged commit 9f84606 into spacetelescope:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants