-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeowners file #230
Update codeowners file #230
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 4 4
Lines 124 124
=======================================
Hits 116 116
Misses 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, GitHub says the file is valid
# Add Kim, Kimberly DuPrie <kduprie@stsci.edu> | ||
src/rad/resources/schemas/*.yaml @kdupriestsci | ||
# Add Kim, Kimberly DuPrie <kduprie@stsci.edu>, add jbrookens@stsci.edu | ||
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens | |
src/rad/resources/schemas/*.yaml @kdupriestsci @jbrookens @WilliamJamieson |
you might also want to add @WilliamJamieson , he requested to be notified of schema changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks.
Resolves RAD-nnnn
Closes #
This PR adds Jason to the list of reviewers for changes of the yaml files.
Checklist
CHANGES.rst
under the corresponding subsection