Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code owners file #226

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

zacharyburnett
Copy link
Collaborator

the CODEOWNERS file defines owners of certain sections of code, and will automatically request a review from the user or team when a respective file is changed

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

I made a simple CODEOWNERS file with a global file pattern *. This is more of a convenience feature than necessary, but in the long run it might be good to have a file in the repo that defines code maintainers and lets external PRs request reviews

Checklist

  • Schema changes discussed at RAD Review Board meeting
  • Added entry in CHANGES.rst under the corresponding subsection
  • Updated relevant roman_datamodels utilities and tests

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2f909e3) 93.54% compared to head (3e129c9) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           4        4           
  Lines         124      124           
=======================================
  Hits          116      116           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

.github/CODEOWNERS Outdated Show resolved Hide resolved
@zacharyburnett zacharyburnett marked this pull request as ready for review March 30, 2023 16:21
@zacharyburnett zacharyburnett merged commit 9f79d3b into spacetelescope:main Mar 30, 2023
@zacharyburnett zacharyburnett deleted the codeowners branch March 30, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants