import tomli as tomllib for docs builds before Python 3.11
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested changes
Mar 9, 2023
There was a problem hiding this comment.
This does not need to change, instead the import in the conf.py needs to be modified to tomllib, see main...WilliamJamieson:bugfix/toml
zacharyburnett
force-pushed
the
tomli_docs
branch
from
427dba4 to
6844e63
Compare
zacharyburnett
changed the title
tomli hard dependency for docstomli as tomllib for docs builds before Python 3.11
|
Could you fix the code-style? |
zacharyburnett
force-pushed
the
tomli_docs
branch
from
7420cd8 to
0533e09
Compare
WilliamJamieson
force-pushed
the
tomli_docs
branch
from
0533e09 to
0d5a192
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 4 4
Lines 124 124
=======================================
Hits 116 116
Misses 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
WilliamJamieson
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomliis implemented read-only astomllibin Python 3.11