-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add source detection schema #215
Conversation
3970e16
to
f682706
Compare
tweakreg_catalog_name: | ||
type: string | ||
tweakreg_catalog: | ||
tag: tag:astropy.org:astropy/table/table-1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need here the tag from asdf-format/asdf-table-schemas
but I'll let @WilliamJamieson confirm the best way to use a table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried that. i couldnt figure out how to create some kind of generic table type to use that tag, so its an astropy table (what DAOStarFinder returns) for now but i can change this if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have to be a table? The short answer is ASDF does not actually support writing to any of the asdf-table-schemas it only supports reading from them. They are also essentially copies of the astropy table schemas, which is what asdf uses to read a theoretically written "asdf table". So for practical reasons it should be the astropy table schema as shown here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the table of a fixed format? In the past we have avoided tables in schemas and formatted them as their own objects. See https://github.com/spacetelescope/rad/blob/main/src/rad/resources/schemas/reference_files/wfi_img_photom-1.0.0.yaml#L18
5c9170c
to
358aa7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Created RDADS ticket to add the new field.
No description provided.