RAD-100: Write a schema for IPC reference file #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdupriestsci
approved these changes
Jan 18, 2023
|
@alphasentaurii, can you confirm that if we leave an optical element field in here (as in the current PR), we can construct the right files in CRDS such that this value is ignored until we actually have a reason to use that field? |
@schlafly yes, right now the only IPC parkeys CRDS is looking for are detector and start_time, anything else would be ignored. |
schlafly
approved these changes
Jan 18, 2023
|
Great. Okay, looks good to me! |
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket to add the interpixel capacitance correction schema.