Array Quantities #192
Merged
Array Quantities #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ArrayQuanitites
| tag: tag:stsci.edu:asdf/core/ndarray-1.0.0 | ||
| datatype: uint16 | ||
| ndim: 5 | ||
| tag: tag:stsci.edu:asdf/unit/quantity-1.1.0 |
There was a problem hiding this comment.
Do we know the exact unit/units involved here? If so should we try to enforce this as part of the schema?
There was a problem hiding this comment.
Same goes for the rest of the quantities involved.
schlafly
reviewed
Dec 2, 2022
I see special archive keywords there, so that maybe it. Though they look new in this PR. |
Good catch! This was vestigial code. |
This was referenced Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket to support quantities for data arrays in the pipeline.
Note: I kept the number of dimensions and types in the files for future reference, depending on future updates to quantity support in asdf.