Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ref_file schema #157

Merged
merged 1 commit into from
Jul 29, 2022
Merged

fix ref_file schema #157

merged 1 commit into from
Jul 29, 2022

Conversation

cshanahan1
Copy link
Collaborator

@cshanahan1 cshanahan1 commented Jul 27, 2022 •
edited
Loading

Fix indentation issue, and change types from 'object' to string - reference file names don't need to be in a dictionary since their only property is their name.

@cshanahan1 cshanahan1 requested a review from nden July 27, 2022 15:39
@nden nden requested a review from kdupriestsci July 28, 2022 15:39
@nden
Copy link
Collaborator

nden commented Jul 28, 2022

LGTM but needs a change log

nden
nden approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden
Copy link
Collaborator

nden commented Jul 28, 2022

needs a rebase

@cshanahan1 cshanahan1 mentioned this pull request Jul 29, 2022
Merged
@nden nden merged commit a1bf9ff into spacetelescope:main Jul 29, 2022
@WilliamJamieson WilliamJamieson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@kdupriestsci kdupriestsci Awaiting requested review from kdupriestsci kdupriestsci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cshanahan1 @nden