Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache CI environment #280

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Sep 21, 2022

image

This PR does the following:

  • expand test matrix (4 Python versions x 2 operating systems)
  • add .flake8 for Flake8 configuration
  • apply formatting to codebase to satisfy ruff checks
  • runs additional MacOS jobs on a weekly scheduled workflow

@zacharyburnett
Copy link
Contributor Author

Several Python versions on Linux are failing due to small differences in test vs reference data:
image

@zacharyburnett
Copy link
Contributor Author

@stscieisenhamer @Witchblade101 are the differences in test success per-Python-version a concern?

@Witchblade101
Copy link
Collaborator

@zacharyburnett Yes. @mfixstsci plans on investigating this.

@zacharyburnett zacharyburnett changed the title cache CI environment and run flake8 checks cache CI environment and run ruff checks Mar 14, 2023
@Witchblade101
Copy link
Collaborator

I suspect this has been resolved in the recent PRs from @mfix, @pllim, and @sosey. We should review this to make sure before the next release.

@pllim
Copy link

pllim commented Sep 11, 2023

ruff might be a step too extreme... but ok. 😸

@zacharyburnett zacharyburnett changed the title cache CI environment and run ruff checks cache CI environment Sep 11, 2023
@zacharyburnett
Copy link
Contributor Author

ruff might be a step too extreme... but ok. 😸

Good point, it does ask for a lot of changes; I'll take it out

@mfixstsci
Copy link
Collaborator

@zacharyburnett should we remove python 3.7 and 3.8 from the testing matrix? Maybe add 3.12 if that's an option!

.github/workflows/ci_cron.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Sep 11, 2023

Alright, I took out 3.7 and 3.8, and added 3.12-dev to the weekly tests (which can be started manually from the web page). We could also add 3.12-dev to the on-push tests as well, but that might be more unstable

@mfixstsci
Copy link
Collaborator

Nice! Thank you @zacharyburnett. We can leave 3.12 out for now, I didn't know how far along it was in development. We can add it once there is a more stable version available. I don't know what it was about python 3.8 and causing our testing matrix to fail. It was the only version that has given us any trouble...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants