Remove pipeline config files #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran a test case where I created some new yaml files and ran Mirage, and everything completed successfully. Also ran Mirage using an old yaml file, and that completed successfully as well. |
|
@hover2pi, when you have a free moment, I've got 2 PRs that I finished a while ago but never got around to asking you to review. This one and the other are largely removing unused files/features, so hopefully should be quick to review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #742
This PR removes the pipeline configuration files (*.cfg) from Mirage. The JWST pipeline has switched to using parameter reference files, and these cfg files are no longer supported.
After some debate, I decided to remove the files completely and not add support for the parameter reference files. This is because the only place Mirage uses them is to linearize a raw dark current file. In this case, the superbias and reference pixel signal is subtracted, and the data are linearized. The simulated sources are added, the ramp is unlinearized, and the superbias and reference pixel signal is added back in. So really, the exact details of how the reference pixel signal is subtracted (that seems like the only step where someone would want to deviate from the defaults) don't matter, as the signal will be added back in at the end.