Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for alternate SOSS wavelength solutions #787

Merged
merged 9 commits into from
Jun 21, 2022

Conversation

hover2pi
Copy link
Collaborator

Allows a user to generate a custom wavelength solution before generating SOSS simulations.

@hover2pi hover2pi changed the title WIP: Adds support for alternate SOSS wavelength solutions Adds support for alternate SOSS wavelength solutions May 19, 2022
@hover2pi hover2pi requested a review from bhilbert4 May 19, 2022 18:51
@hover2pi
Copy link
Collaborator Author

This PR adds support for a user to specify a custom wavelength solution to the SOSS traces, a pupil wheel position to rotate the traces, and a shortcut to save a SOSS seed image without calling the observation generator class. Ready for review and merge!

@hover2pi
Copy link
Collaborator Author

hover2pi commented Jun 6, 2022

Sorry @bhilbert4 , I added more to this PR. mirage.soss_simulator now supports SOSS order 3. I wanted to sneak it in there since we are using it for commissioning analysis. You're probably SUPER busy but anytime you have a chance, this is ready for review. Thanks!

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the delay. Too much to keep track of lately.

mirage/psf/soss_trace.py Outdated Show resolved Hide resolved
mirage/psf/soss_trace.py Outdated Show resolved Hide resolved
@hover2pi
Copy link
Collaborator Author

hover2pi commented Jun 8, 2022

@bhilbert4 the tests that are failing are from:

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_catalog_generation.py::test_get_all_catalogs - requests.exc...
FAILED tests/test_catalog_generation.py::test_gaia_query - requests.exception...
===== 2 failed, 93 passed, 45 skipped, 1842 warnings in 1442.64s (0:24:02) =====

I pulled in master but it didn't seem to fix them. Do you know when these tests were fixed by any chance? Thanks!

@bhilbert4
Copy link
Collaborator

It's been a long time since these tests were touched. #772 made some changes to GAIA queries when they changed their catalog column names, but I don't see these tests failing on other recent PRs. Could it just be an astroquery server problem? The error statements aren't really clear to me, but I wonder about a connection error or something.

@hover2pi
Copy link
Collaborator Author

I ran into this with another package this week! You're right, it has something to do with astroquery searching the Gaia DR3 catalog I think. I'll propose a fix.

@hover2pi
Copy link
Collaborator Author

hover2pi commented Jun 21, 2022

Yup, that did it! astroquery.Gaia.launch_job_async throws a connection error for come reason but launch_job does not. The query result doesn't get cached but I don't think this is a big loss. Do you foresee this being problematic, @bhilbert4 ?

If not, this is ready to merge. Thanks!

@bhilbert4
Copy link
Collaborator

@hover2pi Makes sense to me. You have a couple leftover print statements in create_catalog, and might as well delete the old async Gaia query, but otherwise looks good.

@bhilbert4 bhilbert4 merged commit 090bfe2 into spacetelescope:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants