-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for alternate SOSS wavelength solutions #787
Conversation
…ernate wavelength solution for simulation
…n be saved without running the ramp_genertator for SOSS simulations
This PR adds support for a user to specify a custom wavelength solution to the SOSS traces, a pupil wheel position to rotate the traces, and a shortcut to save a SOSS seed image without calling the observation generator class. Ready for review and merge! |
Sorry @bhilbert4 , I added more to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Sorry for the delay. Too much to keep track of lately.
@bhilbert4 the tests that are failing are from: -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html I pulled in |
It's been a long time since these tests were touched. #772 made some changes to GAIA queries when they changed their catalog column names, but I don't see these tests failing on other recent PRs. Could it just be an astroquery server problem? The error statements aren't really clear to me, but I wonder about a connection error or something. |
I ran into this with another package this week! You're right, it has something to do with astroquery searching the Gaia DR3 catalog I think. I'll propose a fix. |
Yup, that did it! If not, this is ready to merge. Thanks! |
@hover2pi Makes sense to me. You have a couple leftover print statements in create_catalog, and might as well delete the old async Gaia query, but otherwise looks good. |
Allows a user to generate a custom wavelength solution before generating SOSS simulations.