Have WFSS simulations optionally use pickle files of sources #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes were actually made by @NorPirzkal, so I can serve as reviewer. |
|
These updates look good to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes implemented by @NorPirzkal
In this code, catalog_seed_image() saves individual sources and their associated segmentation maps in pickle files, which the disperser then picks up and uses to do the dispersion. By working on individual sources this way, overlapping sources are all handled correctly.
The pickle files are optional. If they do not exist, then the behavior is the same as it has been.
The last note I saw about this on slack, Nor said it is only implemented for point sources and galaxies.
@NorPirzkal anything to add? This is the code you posted to slack on Feb 15.