Fix failing simulations with NIRISS raw darks #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pysiaf 0.14.0 was giving errors when working with some of the new NIRCam apertures. So for now we pin it to 0.13.0. |
|
@hover2pi do you have a few minutes to look this over at some point? |
hover2pi
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the code for reading in dark current files to fix an issue seen when using a raw NIRISS dark. The raw NIRISS darks in the reference file collection contain no zeroframe extension. This was causing zeroframe to be set to None. With this fix, as long as the dark current file uses a RAPID readout pattern, Mirage will grab the initial group of the dark file and use it as the zeroframe.
The larger problem that was being seen with these raw darks was that the metadata was not being read in properly. Updates to the way the metadata are read in have fixed the problem.